-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for white-labeling Explorer #1244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/white-label
branch
2 times, most recently
from
February 11, 2024 15:37
2b28f6c
to
5bfed76
Compare
buberdds
reviewed
Feb 12, 2024
csillag
force-pushed
the
csillag/white-label
branch
3 times, most recently
from
February 13, 2024 01:00
1ec1bca
to
21e0ef8
Compare
csillag
force-pushed
the
csillag/white-label
branch
2 times, most recently
from
February 13, 2024 12:03
e2dec6b
to
191d052
Compare
lubej
reviewed
Feb 13, 2024
lubej
reviewed
Feb 13, 2024
buberdds
reviewed
Feb 13, 2024
buberdds
reviewed
Feb 13, 2024
lubej
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change makes it possible to configure various aspects of the app via settings in the .env file. - Should we show build banners? - If yes, what are the URLs to compare to? - App title and description - Social links Also, support more external / social link types.
csillag
force-pushed
the
csillag/white-label
branch
from
February 13, 2024 15:26
d4571fa
to
0f39ef9
Compare
lukaw3d
reviewed
Feb 13, 2024
lukaw3d
reviewed
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several optional configuration options to
.env
, which can be used when re-branding Explorer.Also, we can now support displaying 3 new links of social links (see at the end):
(Icons suggested by @donouwens )