Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for white-labeling Explorer #1244

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Support for white-labeling Explorer #1244

merged 1 commit into from
Feb 13, 2024

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Feb 10, 2024

This PR adds several optional configuration options to .env, which can be used when re-branding Explorer.

  • Use custom App title
  • Use custom App description
  • Hide build banners (which would otherwise reveal that this is an unofficial / development build)
  • Override social texts and links

Also, we can now support displaying 3 new links of social links (see at the end):

image

(Icons suggested by @donouwens )

Copy link

github-actions bot commented Feb 10, 2024

Deployed to Cloudflare Pages

Latest commit: 0f39ef90f0bfa2de1e9f279fb8c7741c01739be2
Status:✅ Deploy successful!
Preview URL: https://99de5639.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/white-label branch 2 times, most recently from 2b28f6c to 5bfed76 Compare February 11, 2024 15:37
@csillag csillag marked this pull request as ready for review February 11, 2024 15:40
.env Outdated Show resolved Hide resolved
.env Outdated Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
.env Outdated Show resolved Hide resolved
src/app/utils/externalLinks.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
@csillag csillag force-pushed the csillag/white-label branch 3 times, most recently from 1ec1bca to 21e0ef8 Compare February 13, 2024 01:00
@csillag csillag requested a review from buberdds February 13, 2024 01:19
@csillag csillag force-pushed the csillag/white-label branch 2 times, most recently from e2dec6b to 191d052 Compare February 13, 2024 12:03
.env Show resolved Hide resolved
posthtml.config.js Outdated Show resolved Hide resolved
src/app/components/BuildBanner/index.tsx Outdated Show resolved Hide resolved
src/app/utils/externalLinks.ts Outdated Show resolved Hide resolved
src/app/utils/externalLinks.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/locales/en/translation.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@lubej lubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This change makes it possible to configure various aspects of the app
via settings in the .env file.

- Should we show build banners?
  - If yes, what are the URLs to compare to?
- App title and description
- Social links

Also, support more external / social link types.
@csillag csillag force-pushed the csillag/white-label branch from d4571fa to 0f39ef9 Compare February 13, 2024 15:26
@csillag csillag enabled auto-merge February 13, 2024 15:26
@csillag csillag merged commit 64610cb into master Feb 13, 2024
8 checks passed
@csillag csillag deleted the csillag/white-label branch February 13, 2024 15:27
src/config.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants